Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] the Tests.Jupyterhub.Test-Jupyterlab-Git-Notebook #1014

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Nov 8, 2023

The pre-filled input text has been changed in JupyterHub 3.6 when compared to JupyterHub 3.5 used in previous notebook image.

Relates to: opendatahub-io/notebooks#261

CI: rhods-ci-pr-test/2235 ✅

@jstourac jstourac self-assigned this Nov 13, 2023
@jstourac jstourac added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Nov 13, 2023
The pre-filled input text has been changed in JupyterHub 3.6 when
compared to JupyterHub 3.5 used in previous notebook image.

Relates to: opendatahub-io/notebooks#261
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
389 0 0 389 100

@jstourac
Copy link
Member Author

Okay, this waited for too long. Let's merge at least this part for one of the failing tests in the suite and I'll provide a fix for the second one later in a different PR.

@jstourac jstourac marked this pull request as ready for review December 13, 2023 17:17
@jstourac jstourac marked this pull request as draft December 13, 2023 17:36
@jstourac jstourac marked this pull request as ready for review December 13, 2023 18:06
@jstourac jstourac added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Dec 13, 2023
@jstourac jstourac merged commit cf6b188 into red-hat-data-services:master Dec 14, 2023
7 checks passed
@jstourac jstourac deleted the fixNtbGit branch December 14, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants