[Fix] indentation of the robotframework keyword #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -71,7 +71,7 @@ | |||
| ${result} = Run Keyword And Return Status | |||
| ... Oc Get kind=ClusterServiceVersion namespace=${namespace} name=${current_csv_name} | |||
| ELSE | |||
| ${result} = Set Variable False | |||
| ${result} = Set Variable False | |||
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead
There was a problem hiding this comment.
Yeah, let's fix it in the future eventually since there are more occurrences of this in the file.
Robot Results
|
|
Beautiful - now we can demand every PR to pass the dryrun!
Can we do it? |
This indentation bug resulted in the test failure:
```
==============================================================================
Install "Embedded Operator" RHODS | FAIL |
No keyword with name '${result} = Set Variable' found.
------------------------------------------------------------------------------
Verify Embedded RHODS Installation | PASS |
------------------------------------------------------------------------------
Tests.Deploy.Operators.Rhods Operator.Embedded Operator | FAIL |
2 tests, 1 passed, 1 failed
```
jstourac
added
the
enhancements
|
Kudos, SonarCloud Quality Gate passed!
|
jgarciao
approved these changes
Nov 2, 2023
jgarciao
added a commit
to jgarciao/ods-ci
that referenced
this pull request
Nov 6, 2023
…s#1001) This indentation bug resulted in the test failure: ``` ============================================================================== Install "Embedded Operator" RHODS | FAIL | No keyword with name '${result} = Set Variable' found. ------------------------------------------------------------------------------ Verify Embedded RHODS Installation | PASS | ------------------------------------------------------------------------------ Tests.Deploy.Operators.Rhods Operator.Embedded Operator | FAIL | 2 tests, 1 passed, 1 failed ``` Co-authored-by: Jorge <[email protected]>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
…s#1001) This indentation bug resulted in the test failure: ``` ============================================================================== Install "Embedded Operator" RHODS | FAIL | No keyword with name '${result} = Set Variable' found. ------------------------------------------------------------------------------ Verify Embedded RHODS Installation | PASS | ------------------------------------------------------------------------------ Tests.Deploy.Operators.Rhods Operator.Embedded Operator | FAIL | 2 tests, 1 passed, 1 failed ``` Co-authored-by: Jorge <[email protected]>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
…s#1001) This indentation bug resulted in the test failure: ``` ============================================================================== Install "Embedded Operator" RHODS | FAIL | No keyword with name '${result} = Set Variable' found. ------------------------------------------------------------------------------ Verify Embedded RHODS Installation | PASS | ------------------------------------------------------------------------------ Tests.Deploy.Operators.Rhods Operator.Embedded Operator | FAIL | 2 tests, 1 passed, 1 failed ``` Co-authored-by: Jorge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indentation bug resulted in the test failure: