Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types_output #163

Merged
merged 19 commits into from
Feb 15, 2025
Merged

Add types_output #163

merged 19 commits into from
Feb 15, 2025

Conversation

Ketasaja
Copy link
Contributor

@Ketasaja Ketasaja commented Feb 1, 2025

Closes #77. Almost all of the code was written by @passhley in #79.

Co-authored-by: pashleyy <[email protected]>
@sasial-dev sasial-dev self-assigned this Feb 2, 2025
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting back to you! I half finished the review a while ago but didn't have time to fully go through it until now.

@Ketasaja Ketasaja requested a review from sasial-dev February 15, 2025 21:09
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just please fix your autoformatter playing havoc again...

})()

local client = luau.load(clientCode, {
debugName = "Client",
codegenEnabled = false,
environment = environment
environment = environment,
Copy link
Collaborator

@sasial-dev sasial-dev Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert unrelated changes to this file

@sasial-dev sasial-dev merged commit 608c066 into red-blox:0.6.x Feb 15, 2025
2 checks passed
@sasial-dev
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add option for exporting zap types into separate file.
2 participants