Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector #6722

Merged
merged 4 commits into from
Feb 7, 2025
Merged

[PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector #6722

merged 4 commits into from
Feb 7, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @SpencerMalone

@samsonasik samsonasik marked this pull request as draft February 7, 2025 04:21
@samsonasik
Copy link
Member Author

It seems cause another test error, will look more...

@samsonasik samsonasik marked this pull request as ready for review February 7, 2025 05:54
@samsonasik
Copy link
Member Author

Fixed 🎉 , it actually other fixtures needs update on after rename with remove unused import anabled as well with FQCN docblock

rector-src/rules-tests/Renaming/Rector/Name/RenameClassRector/config/configured_rule.php

Line 22 in ecd8b37

$rectorConfig->removeUnusedImports();

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 59d4bca into main Feb 7, 2025
44 checks passed
@samsonasik samsonasik deleted the with-fqcn-doc branch February 7, 2025 05:56
@SpencerMalone
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import / use statement removal fails when docblock references un-namespaced (and unrelated) class
2 participants
@samsonasik @SpencerMalone