Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NewlineBeforeNewAssignSetRector variable as same name like property #6705

Merged
merged 5 commits into from
Jan 31, 2025
Merged

fix: NewlineBeforeNewAssignSetRector variable as same name like property #6705

merged 5 commits into from
Jan 31, 2025

Conversation

guideloince
Copy link
Contributor

Hi people,

I open an issue and i try to fix.

I'm not sure for a development code 🙏

Thanks for your feedback.

@samsonasik
Copy link
Member

Please add test fixture for it at https://github.com/rectorphp/rector-src/tree/main/rules-tests/CodingStyle/Rector/ClassMethod/NewlineBeforeNewAssignSetRector/Fixture

@guideloince
Copy link
Contributor Author

Please add test fixture for it at https://github.com/rectorphp/rector-src/tree/main/rules-tests/CodingStyle/Rector/ClassMethod/NewlineBeforeNewAssignSetRector/Fixture

Done !

@guideloince guideloince force-pushed the fix/NewlineBeforeNewAssignSetRector branch from d052ec1 to 798c1a8 Compare January 30, 2025 09:12
@guideloince guideloince force-pushed the fix/NewlineBeforeNewAssignSetRector branch from 798c1a8 to 2efbeea Compare January 30, 2025 09:18
samsonasik
samsonasik approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try

@samsonasik samsonasik merged commit c781983 into rectorphp:main Jan 31, 2025
44 checks passed
@samsonasik samsonasik mentioned this pull request Jan 31, 2025
Closed
@samsonasik
Copy link
Member

Thank you @guideloince

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guideloince @samsonasik