Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude node modules path #6702

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Exclude node modules path #6702

merged 3 commits into from
Jan 28, 2025

Conversation

vaishnavyogesh
Copy link
Contributor

@vaishnavyogesh vaishnavyogesh commented Jan 28, 2025 •
edited by samsonasik
Loading

@samsonasik to review

Changes:

  • exclude root node_modules path
  • add fixed files resulting from running composer fix-cs
  • refactor to use Finder::hasResults() instead of comparing it's iterator count

Closes rectorphp/rector#8988

@samsonasik samsonasik merged commit c9818c7 into rectorphp:main Jan 28, 2025
40 checks passed
@samsonasik
Copy link
Member

Thank you @vaishnavyogesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude root node_modules path
2 participants
@vaishnavyogesh @samsonasik