[TypeDeclaration] handle explicit if else new on ReturnTypeFromReturnNewRector

[samsonasik]

#6102 (review)

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review, for me, using SilentVoidResolver only is actually already enough, as that cover many edge cases already, but you decide ;)

[samsonasik]

Another more consist way is to rename hasClassMethodRootReturn to something else, eg: hasOnlyReturnWithExpr, then we traverse, exclude inner class/function/closure to get Return_.

If there is Return_ without Expr in collection, then return false, as possible void

Then, lastly, verify Silent Void to handle no return like current PR change as last resort, wdyt?

[TomasVotruba]

Neat solution, I like it 👍

Another more consist way is to rename hasClassMethodRootReturn to something else, eg: hasOnlyReturnWithExpr, then we traverse, exclude inner class/function/closure to get Return_.

Agreed, the name deserves an improvement :)

[samsonasik]

implemented 👍

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[TomasVotruba]

Thank you 👍