Add c8 for code coverage reporting fail on less than 95% coverage #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase coverage to meet these standards I’m so close to 100% but testing some of these possible error conditions is beyond what I can figure out tonight. I feel like the possible state machine of errors that SI can see is larger than the errors that can actually be produced. If I could prove that I could have less code, but since I can’t I’m going to have to rely on reason instead of tests to prove it. Also reporting of coverage sucks on node 10, it’s less than the other versions, so I disabled it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m so close to 100% but testing some of these possible error conditions is beyond what I can figure out tonight. I feel like the possible state machine of errors that SI can see is larger than the errors that can actually be produced. If I could prove that I could have less code, but since I can’t I’m going to have to rely on reason instead of tests to prove it.
Also reporting of coverage sucks on node 10, it’s less than the other versions, so I disabled it.