Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sarplus #955

Merged
merged 10 commits into from
Oct 16, 2019
Merged

sarplus #955

merged 10 commits into from
Oct 16, 2019

Conversation

eisber
Copy link
Collaborator

@eisber eisber commented Oct 14, 2019

Description

Spark/C++ based implementation of the SAR algorithm. Main goal is to scale further in terms of number of items/ratings.

(I'll add publishing of the pip and maven jar in a separate PR)

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few comments / questions

AUTHORS.md Show resolved Hide resolved
contrib/sarplus/README.md Outdated Show resolved Hide resolved
contrib/sarplus/README.md Outdated Show resolved Hide resolved
contrib/sarplus/README.md Show resolved Hide resolved
contrib/sarplus/README.md Outdated Show resolved Hide resolved
contrib/sarplus/README.md Show resolved Hide resolved
contrib/sarplus/README.md Outdated Show resolved Hide resolved
contrib/sarplus/python/setup.py Show resolved Hide resolved
contrib/sarplus/scala/python/setup.py Show resolved Hide resolved
contrib/sarplus/python/pysarplus/SARPlus.py Show resolved Hide resolved
Copy link
Collaborator

@yueguoguo yueguoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eisber - just some minor comments.

contrib/sarplus/README.md Show resolved Hide resolved
contrib/sarplus/README.md Show resolved Hide resolved
contrib/sarplus/azure-pipelines.yml Show resolved Hide resolved
contrib/sarplus/azure-pipelines.yml Show resolved Hide resolved
contrib/sarplus/python/pysarplus/SARPlus.py Show resolved Hide resolved
contrib/sarplus/python/tests/sample-input.txt Show resolved Hide resolved
Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants