Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of node12 actions #1844

Merged
merged 7 commits into from
Nov 14, 2022
Merged

Fix deprecation of node12 actions #1844

merged 7 commits into from
Nov 14, 2022

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Nov 11, 2022

Description

We are getting some warnings that we need to update the node12 to node16 and that affects some commands in GitHub actions. See https://github.com/microsoft/recommenders/actions/runs/3442907860

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2

hopefully nothing breaks :-)

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Copy link
Collaborator Author

@simonzhaoms let's hope we are not breaking anything :-)

@miguelgfierro miguelgfierro merged commit e3cceeb into staging Nov 14, 2022
@miguelgfierro miguelgfierro deleted the checkout3 branch November 14, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants