Staging to main to merge AzureML tests, improvements in SAR+ and improvements in notebooks #1730
Conversation
* Implement time_now * Update dependency versions * Revert scalatest version * Revert all dependency versions * Add tests for time_now when set to other values than the latest timestamp * Typos and fix static analysis warnings * Format code
merge with latest staging
* Bump sarplus version to 0.6.6 * Update sarplus docs * Update DEVELOPMENT.md
Update docker image reference to internal registry
AzureML Tests
Update AzureML test documentation
SahitiCheguru
requested review from
miguelgfierro,
yueguoguo,
gramhagen,
anargyri,
loomlike and
wutaomsft
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #1730 +/- ##
==========================================
- Coverage 24.65% 23.20% -1.46%
==========================================
Files 88 88
Lines 9121 9142 +21
==========================================
- Hits 2249 2121 -128
- Misses 6872 7021 +149
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
miguelgfierro
changed the title
|
@SahitiCheguru thanks for this PR, we were planning to do it after @pradnyeshjoshi has finished his work, but since you did it, we will use it. |
| @@ -53,6 +57,8 @@ To contributors: please add your name to the list when you submit a patch to the | |||
| * **[Beth Zeranski](https://github.com/bethz)** | |||
There was a problem hiding this comment.
@pradnyeshjoshi feel free to add your name to the list of authors. This can be done in a different PR.
| # Not recommended to change this. | ||
| parser.add_argument( | ||
| "--condafile", | ||
| "--wheelfile", | ||
| action="store", | ||
| default="./reco.yaml", | ||
| help="file with environment variables", | ||
| default="./dist/recommenders-1.0.0-py3-none-any.whl", | ||
| help="recommenders whl file path", |
There was a problem hiding this comment.
@pradnyeshjoshi can you elaborate what you are doing here?
There was a problem hiding this comment.
@miguelgfierro on GitHub machines, I build a wheel from the checked out repo and wheelfile used to be the path to the wheel file (used to set up AzureML environment). The wheel file name generated by bdist command is not constant, so this is how I locate the wheel file now: https://github.com/microsoft/recommenders/blob/53c01881843b256ab33bffffa91bdf6e363e6f6a/tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py#L464
I will remove the wheelfile argument in another PR since this argument is not being used anymore.
Description
This is a sample pull requestRelated Issues
Checklist:
staging branchand not tomain branch.