-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtualenv support and info #1520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
databricks_cli>=0.8.6,<1 | ||
pyarrow>=0.8.0,<1.0.0 | ||
pyspark>=2.4.5,<3.0.0 | ||
cmake>=3.18.4.post1 | ||
xlearn==0.40a1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after this is merged into staging, a new documentation job will be triggered. In the past I had problems when using pyspark and readthedocs. We should check if this causes a problem this time, FYI @YanZhangADS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a DSVM, compilation works and the docs look ok on Firefox Let's check on readthedocs too after the merge.
Codecov Report
@@ Coverage Diff @@
## staging #1520 +/- ##
============================================
- Coverage 74.23% 61.95% -12.29%
============================================
Files 84 84
Lines 8369 8369
============================================
- Hits 6213 5185 -1028
- Misses 2156 3184 +1028
Continue to review full report at Codecov.
|
Description
Modifications required to support virtualenv which is an extension of venv but differs somewhat in installation.
Related Issues
Checklist:
staging branch
and not tomain branch
.