Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no_std build by removing unused dependency #433

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: no_std build by removing unused dependency #433

merged 1 commit into from
Feb 18, 2025

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Feb 18, 2025 •
edited
Loading

Motivation

no_std is broken in 1.13.0 due to the addition of hex dependency which by default enables the "std" feature.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@DaniPopes DaniPopes requested a review from prestwich as a code owner February 18, 2025 17:52
@prestwich prestwich merged commit 535dc02 into recmo:main Feb 18, 2025
17 checks passed
@prestwich
Copy link
Collaborator

if you make a release PR we can release 0.13.1 and yank 0.13.0 if necessary

@DaniPopes DaniPopes mentioned this pull request Feb 18, 2025
Merged
@DaniPopes DaniPopes deleted the fix-hex branch February 18, 2025 18:18
@DaniPopes
Copy link
Contributor Author

#434

@clabby
Copy link

clabby commented Feb 18, 2025

Thanks!

@prestwich
Copy link
Collaborator

this was released as 1.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaniPopes @prestwich @clabby @mattsse