-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OCaml 4.10 #2529
Conversation
Thanks, @kit-ty-kate! I predict this is gonna need some 4.10 specific expected test outputs as in https://github.com/facebook/reason/blob/master/formatTest/errorTests/expected_output/comments1.re.4.09.0 Should probaly be enough to copy them from the 4.09 ones. |
Can we just alias the 4.10 expected test outputs to the 4.09 ones since we don't expect any changes? |
@jordwalke was that what you were asking? The CI image used is a different one because the |
Thanks for thinking about |
hey @kit-ty-kate I think it's fine to use the ocurrent docker image, but you missed adding the pipeline for 4.10.0 here |
For information: the final release of OCaml 4.10.0 is expected next week |
OCaml 4.10.0 has now been released. |
Currently reason does not support OCaml 4.10 and the first beta is around the corner. This PR adds support for OCaml 4.10