Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG or ENHANCEMENT] let%ppx in signature support #2488

Closed
Et7f3 opened this issue Nov 9, 2019 · 1 comment · Fixed by #2770
Closed

[BUG or ENHANCEMENT] let%ppx in signature support #2488

Et7f3 opened this issue Nov 9, 2019 · 1 comment · Fixed by #2770

Comments

@Et7f3
Copy link
Contributor

Et7f3 commented Nov 9, 2019

In OCaml we can write ppx annotation in the signature
val%nativeComponent foo: bar

refmt sugest me [%%nativeComponent: let foo: bar].

Is their a reason why such change ?

Also let%ppx foo = bar is perfectly fine in Reason see https://github.com/jaredly/reason-macros

Can this be changed to have parity with OCaml and be more consistent.

on Refmt Reason 3.5.2 @ e6229f9a

$ esy refmt -i true
let%nativeComponent foo: bar;
Line 1, characters 3-4:
Error: Syntax error
@Et7f3
Copy link
Contributor Author

Et7f3 commented Nov 9, 2019

This is related to #2478 (have %ppx in signature allowed) and should have the same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant