Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5 component refactor: Tooltip #235

Open
2 of 14 tasks
ksolanki7 opened this issue Dec 4, 2024 · 2 comments
Open
2 of 14 tasks

v5 component refactor: Tooltip #235

ksolanki7 opened this issue Dec 4, 2024 · 2 comments
Assignees
@ksolanki7
Labels
feature The issue relates to a new feature v5 Issues for v5 release

Comments

@ksolanki7
Copy link
Contributor

ksolanki7 commented Dec 4, 2024 •
edited
Loading

Abstract

As part of the v5 Elements release, each component will be reviewed and refactored to ensure best practice and design system alignment

Specification

PR Checklist

Developer Checklist

  • Styles alignment between Design System and Elements
  • Check design tokens in Figma and implement CSS variable tokens if available for relevant component
  • Align with accessibility standards / spec as per above
  • If relevant, break down component into Styles Only and React component structures
  • Ensure all variants of components are documented as appropriate
  • Ensure unit test coverage is adequate for component
  • Update documentation in MDX file as per guidelines
  • Changelog updated to reflect a single beta version per component ideally

Release Checklist

  • Approved PR merged to main
  • Design & product review and feedback addressed by developer
  • Beta release by product / engineering lead to next beta version

Additional Context or Information
@ksolanki7 ksolanki7 added feature The issue relates to a new feature v5 Issues for v5 release labels Dec 4, 2024
@github-project-automation github-project-automation bot moved this to To Review in Elements Roadmap Dec 4, 2024
@ksolanki7 ksolanki7 moved this from To Review to Todo in Elements Roadmap Dec 4, 2024
@ksolanki7 ksolanki7 moved this from Todo to In Progress in Elements Roadmap Dec 4, 2024
@ksolanki7 ksolanki7 self-assigned this Dec 4, 2024
ksolanki7 added a commit that referenced this issue Dec 4, 2024
@ksolanki7
feat: #235 v4 Deprecated existing Tooltip
52482f9
ksolanki7 added a commit that referenced this issue Dec 6, 2024
@ksolanki7
feat: #235 v4 Deprecated existing Tooltip (#237)
f37b6dd 
* feat: #235 v4 Deprecated existing Tooltip

* Fix issue with export naming
@ksolanki7 ksolanki7 mentioned this issue Dec 6, 2024
Open
11 tasks
@ksolanki7
Copy link
Contributor Author

@HollyJoyPhillips I have to descope this ticket.
New ticket for Conditional display for tooltip - #238

@ksolanki7 ksolanki7 mentioned this issue Jan 14, 2025
Open
ksolanki7 added a commit that referenced this issue Jan 17, 2025
@ksolanki7
feat: #235 v5 Tooltip component (#239)
a4e13fd 
* feat: #218 v5 Tooltip component

* Nitpick update - naming convention correction

* Updated tooltip to support the PR feedback.

* Remove aria-live from tooltip - not required

* Fix issue with story display over canvas

* Fix the tooltip fontweight to use variable
@ksolanki7 ksolanki7 moved this from In Progress to QA in Elements Roadmap Jan 21, 2025
@andrei-dragut
Copy link

@ksolanki7 Looks good. Good to go

@ksolanki7 ksolanki7 moved this from QA to Done in Elements Roadmap Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksolanki7 ksolanki7

Labels
feature The issue relates to a new feature v5 Issues for v5 release
Projects
Elements Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksolanki7 @andrei-dragut