This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Fix the check for if the ResultSets schema needs to be initialized #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
approved these changes
Aug 3, 2019
Table::size() is not the number of columns in the table.
tgoyne
force-pushed
the
tg/resultsets-schema-init
branch
from
f8c2df1 to
368205c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table::size() is not the number of columns in the table.
This probably worked out okay in practice because it "works" as long as the user creates at least 4 subscriptions, but until they do it resulted in a bunch of extra empty write transactions.