Fix incorrect results for sort/distinct over a link after a sort #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a sort or distinct over links was done on an already-sorted TableView, the link translation map was done using the unsorted rows, resulting in the second sort/distinct being done with the incorrect values.
tgoyne
force-pushed
the
tg/distinct-over-links-after-sort
branch
from
cc09edd to
3bb6a5c
Compare
|
Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-3102/2/Performance_Report |
ironage
reviewed
Oct 1, 2018
|
I don't see any test failures related to stale rows over sync_if_needed(). |
|
Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-3102/3/Performance_Report |
ironage
approved these changes
Oct 1, 2018
|
Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-3102/4/Performance_Report |
|
Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-3102/5/Performance_Report |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sort or distinct over links was done on an already-sorted TableView, the link translation map was done using the unsorted rows, resulting in the second sort/distinct being done with the incorrect values.
This appears to have been broken since the functionality was first introduced and is not a regression.
Reported at realm/realm-swift#5936.