Fix aget/aset use with objects #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I asked about assigning new indices via is not a correct program, but he he admits that it is also sufficiently host-y where it's a bit of an edgecase. |
This removes the interop macros which used aget/aset and prevented Closure naming mangling, now normal property and method access is used where possible, and goog.object used when using variable keys. Further testing is needed to ensure this works correctly with Closure, as there are some properties that are used with goog.object in one place, and as property in another. Fixes #324
- Use two types to store native and hiccup data - Rename comp to component so cljs.core/comp is not shadowd - Use className instead of class property - Rename name property to tag - Use static properties for React key Use of static properties in this and other commits shrinks test-suite output size by 2-3kB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the interop macros which used aget/aset and prevented
Closure naming mangling, now normal property and method access is used
where possible, and goog.object used when using variable keys. Further
testing is needed to ensure this works correctly with Closure, as there
are some properties that are used with goog.object in one place, and as
property in another.
Fixes #324
This still throws several assertion errors, caused by
asetcurrently checking that index is inside existing array, though JS arrays automatically grow when assigning values to new indices:Assert failed: (< idx (alength array))