Extends React.Component directly without create-react-class #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! I'll check this at some point. I think I tried something similar but hit problems with some interop calls, so I'll need to try this with some projects to see if our tests are comprehensive. If this works, fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, reagent is using
create-react-classpackage which is no longer maintained upstream. This PR creates component by extendingReact.Componentas recommended by React.This should improve compatibility with current and future versions of react.
All test passed, no tests were modified.
I did not remove the dependency to create-react-class as it was required for some test cases. To be done on future PR.