Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feb 2024 newsletter #247

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Add Feb 2024 newsletter #247

merged 6 commits into from
Feb 1, 2024

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 30, 2024

This swaps this content over for our website blog,
and makes that the official place for writing new blog content!


📚 Documentation preview 📚: https://read-the-docs-website--247.com.readthedocs.build/

This swaps this content over for our website blog,
and makes that the official place for writing new blog content!
@ericholscher ericholscher requested a review from a team as a code owner January 30, 2024 22:01
@ericholscher ericholscher linked an issue Jan 31, 2024 that may be closed by this pull request
@agjohnson
Copy link
Contributor

I thought there might be some bugs with pages like:

https://read-the-docs-website--247.com.readthedocs.build/blog/category/newsletter.html

But I think the issue was just missing content actually, the category page looks to generate correctly with proper posts (instead of drafts, when I tested things).

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks quite a bit better on the blog here 👍

@ericholscher
Copy link
Member Author

Feedback should mostly be resolved, and ready to go live tomorrow.

@@ -1,6 +1,7 @@
{% macro menu_main() %}
<a class="item{% if page and page.slug == 'features' %} active" aria-current="page{% endif %}" href="{{ SITEURL }}/features/">Features</a>
<a class="item{% if page and page.slug == 'pricing' %} active" aria-current="page{% endif %}" href="{{ SITEURL }}/pricing/">Pricing</a>
<a class="item{% if page and 'blog' in page.slug %} active" aria-current="page{% endif %}" href="{{ SITEURL }}/blog/">Blog</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay for now, but it also doesn't feel like a great top level menu item. I'd like to revisit re-re-naming the "Features" and turning that into a dropdown menu to help reduce bloat on the top menu.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea -- would be nice to have Resources or similar as a top level with Blog, Docs, Support in there probably.

@ericholscher ericholscher enabled auto-merge (squash) February 1, 2024 20:51
@ericholscher ericholscher merged commit 3d6c702 into main Feb 1, 2024
4 checks passed
@stsewd stsewd deleted the newsletter-feb-2024 branch February 1, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write February newsletter on the new website
4 participants