Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic deployment to pypi when tag is pushed #833

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Letme
Copy link

@Letme Letme commented Oct 16, 2019

setuptools_scm works that it provides a version even when you build it
locally and it generates the version into a file at the time of
packaging, which means there is no run-time-dependenty on the
setuptools_scm package later on (and also no dependency on git, or
internet access). This makes a simplified release flow, because it
enables you to just add a tag and CI pushes the end package to the PyPi
for end users to use.

Option is also to provide development packages, etc. (just the matter of
how far we want to take it). There is no required tag name, although we
should follow some of the standard formats of Major.minor.patch or
whatever it is preferred.

Before merging we should fill in the secure password (hashed with original repo) and username of the maintainer for pypi. This is added as allow edits from maintainers so that they can add all the details before merging.

closes #812
if we decide to go this way.

Letme added 3 commits October 16, 2019 11:10
`setuptools_scm` works that it provides a version even when you build it
locally and it generates the version into a file at the time of
packaging, which means there is no run-time-dependenty on the
`setuptools_scm` package later on (and also no dependency on git, or
internet access). This makes a simplified release flow, because it
enables you to just add a tag and CI pushes the end package to the PyPi
for end users to use.

Option is also to provide development packages, etc. (just the matter of
how far we want to take it). There is no required tag name, although we
should follow some of the standard formats of Major.minor.patch or
whatever it is preferred.
@Blendify Blendify requested a review from agjohnson October 23, 2019 08:36
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sort of leaning towards the implementation in #822 instead of setuptools_scm as bumpversion seems ot be more flexible. We've been wanting to automate release with Travis though, I'm definitely 👍 on this part of the change.

We can probably treat Travis tag releases and the underlying version update mechanism as separate work, they are independent pieces. Perhaps back out the setuptools_scm bits here and we can focus on this first? Version change automation is not super high priority or blocking issue atm, but making it easier for core theme team to cut releases is one of our priorities.

.travis.yml Show resolved Hide resolved
@Letme
Copy link
Author

Letme commented Oct 24, 2019

OK, I will prepare travis only change for releasing on tag. I am against effort of keeping bumpversion (commited) and tags in sync, but that's just lazy me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants