Switch to a native code font stack #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't exactly include a before and after as it depends on what fonts you have. Here's what it looks like with this change for me:
|
jessetan
requested changes
Apr 17, 2018
There was a problem hiding this comment.
The font stack itself looks good and works as intended on macOS and Windows as far as I've tested.
Remarks:
- Font change is not applied to parsed-literal blocks (section 3.4.5 of demo docs), maybe move
font-familyfromdiv[class^='highlight'] pretopre.literal-block, div[class^='highlight'] - Font change is not applied to option list (section 4.1.3 of demo docs). The font of
pre, code, .rst-content tt, .rst-content code, kbd, sampis set tomonospaceby_reset.sass, I think all of these can use the code font. - Changelog should document this as a new feature
|
Good catches. |
|
I have made the requested changes. |
jessetan
approved these changes
Apr 20, 2018
docs/changelog.rst
Outdated
| @@ -17,6 +17,8 @@ Fixes | |||
| Other Changes | |||
| -------------- | |||
|
|
|||
| * Modified native font stack (#612) | |||
There was a problem hiding this comment.
Maybe mention this only applies to code: "Changed code and literals to use a native font stack"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps the existing monospace font stack to use a native font stack (a list of fonts where some are already on the user's computer).
Fixes #524 (that's also where a lot of the previous discussion about this is).
Fixes #460.