Cast maxdepth to an int.

[Carreau]

closes #334

[agjohnson]

I'm generally -1 on magic in templates, but this might be the only way to fix this. Is there any way of coercing the template options through the Sphinx application API?

[Carreau]

I'm not sure how to do it differently. I looked at several other sphinx
theme to figure out how they were having default value that were integers.
That's the only way I found. I agree that I would prefer doing it through
an explicit python API but as far as I can tell, we need to patch Sphinx
for that.

On Oct 18, 2016 11:34, "Anthony" [email protected] wrote:

@agjohnson commented on this pull request.

I'm generally -1 on magic in templates, but this might be the only way to
fix this. Is there any way of coercing the template options through the
Sphinx application API?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#335 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUez9a0whviVF_BejRPbdKIeyQ0X0vlks5q1RFEgaJpZM4KZAHs
.

[Carreau]

Get we get that in to fix the theme ? Otherwise it is plainly broken for some projects.

Thanks !

[ericholscher]

Looks good to me. We can try and fix this another way over time if need be.

[Carreau]

Thanks, appreciate it.