-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: unpin Pillow for unsupported Python versions #9473
Conversation
Pillow supports specific versions of Python. They are shown in this table: https://pillow.readthedocs.io/en/stable/installation.html#python-support For unsupported Python versions, they don't offer wheels. Meaning that Read the Docs needs to compile the Pillow version on each build. Ideally, we should unpin Pillow completely and install always the latest version that's supported for this particular Python (as we do with other requirements like Sphinx or MkDocs). However, this commit kept old Python versions to keep using `Pillow==5.4.1`.
In case my query is correct, 4373 projects are currently affected by this. Note that this will have a good impact regarding build time on those projects. |
I'm putting `pillow` first to be able to compare it when running the tests.
Interesting... I don't have this test failing locally 🤔
|
Nah, I was just not running that file 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update our docs at https://docs.readthedocs.io/en/stable/build-default-versions.html#python to mention this.
Co-authored-by: Santos Gallegos <[email protected]>
'commonmark==0.8.1', | ||
'recommonmark==0.5.0', | ||
] | ||
requirements = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we can initialize this with the contents from https://github.com/readthedocs/readthedocs.org/pull/9473/files#diff-ae3dd3afeb422a62b42a209aa813ca5a60b9a22cf6c20f7bc3a1b1abf63a5148R181-R187
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where that link points exactly because it doesn't show me a specific line or similar.
However, I've done it in this way to avoid changing all the tests that require a specific order of requirements to check them.
I want to merge and deploy this today, but if you feel strongly about this, we can continue talking and change it later.
Pillow supports specific versions of Python. They are shown in this table:
https://pillow.readthedocs.io/en/stable/installation.html#python-support
For unsupported Python versions, they don't offer wheels. Meaning that Read the
Docs needs to compile the Pillow version on each build.
Ideally, we should unpin Pillow completely and install always the latest version
that's supported for this particular Python (as we do with other requirements
like Sphinx or MkDocs).
However, this commit kept old Python versions to keep using
Pillow==5.4.1
.Closes #9118
📚 Documentation preview 📚: https://docs--9473.org.readthedocs.build/en/9473/