Refactor tasks into decorators #4666
Conversation
Pylint doesn't like bounded tasks
| step = UpdateDocsTaskStep(task=self) | ||
| return step.run(*args, **kwargs) | ||
| @app.task(bind=True, max_retries=5, default_retry_delay=7 * 60) | ||
| def update_docs_task(self, project_id, *args, **kwargs): |
There was a problem hiding this comment.
Pylint doesn't like binded task, the self parameter gets injected by the decorator.
| tasks.SyncRepositoryTask().run( | ||
| version.pk, | ||
| ) | ||
| tasks.sync_repository_task(version.pk) |
There was a problem hiding this comment.
I assume that calling directly to run is the same as executing the task on the same host.
There was a problem hiding this comment.
Yeah, this should be equal
stsewd
removed
the
PR: work in progress
|
I think this is ready, we can refactor more: classes aren't needed here, we can refactor those to be just functions. Let me know if you want me to do that here, or maybe we can do it in another PR. Also, I tested with some builds locally (also some commands), it works. |
| tasks.SyncRepositoryTask().run( | ||
| version.pk, | ||
| ) | ||
| tasks.sync_repository_task(version.pk) |
There was a problem hiding this comment.
Yeah, this should be equal
|
Looks like need to fix some linter errors |
|
Yeah i think in part due to my resolve. Seems to be okay now though |
|
Error fixed, it was because of #4653 |
Closes #3973
This will also helps with #3984 later