Skip to content

Commit

Permalink
Remove showing errors from build.error
Browse files Browse the repository at this point in the history
We are using the `Notification`s attached to the object now.
These old errors are migrated to the new system by a one-time script.
  • Loading branch information
humitos committed Jan 3, 2024
1 parent 35b64cc commit d4951a8
Showing 1 changed file with 0 additions and 25 deletions.
25 changes: 0 additions & 25 deletions readthedocs/templates/builds/build_detail.html
Original file line number Diff line number Diff line change
Expand Up @@ -225,31 +225,6 @@ <h3>{{ notification.get_message.type|title }}</h3>
{% endif %}
{% endfor %}

<div class="build-error"
data-bind="visible: error"
style="display: none;">
<h3>{% trans "Error" %}</h3>
<p class="build-error"
data-bind="text: error">
{#
I'd like to use ``build.error|urlize`` here, so we can have nice links.
However, this is not possible because we are using `data-bind="text: error"`
which means that Knockout.js will use the `.error` attribute to fill
the content of this tag dynamically.
#}
{{ build.error|urlize }}
</p>
<p>
{% block github_issue_link %}
{% if issue_url %}
{% blocktrans trimmed with url=issue_url %}
<a href="{{ url }}">Report any build issues here</a>.
{% endblocktrans %}
{% endif %}
{% endblock %}
</p>
</div>

<div id="build-commands"
class="build-command-list"
data-bind="visible: commands, foreach: display_commands"
Expand Down

0 comments on commit d4951a8

Please sign in to comment.