Don't display the build suggestions div if there are no suggestions (#…

…3389) This added extraneous spacing to the build page.
readthedocs · Dec 14, 2017 · 2bdc987 · 2bdc987
1 parent 00b081d
commit 2bdc987
Showing 1 changed file with 19 additions and 20 deletions.
diff --git a/readthedocs/templates/builds/build_detail.html b/readthedocs/templates/builds/build_detail.html
@@ -92,28 +92,27 @@
       </span>
     </div>
 
-    <div class="build-ideas">
     {% if not build.success and build.commands.count < 4 %}
-      <p>
-
-        {% url 'wipe_version' build.version.project.slug build.version.slug as wipe_url %}
-        {% blocktrans %}
-        Having trouble with your build environment?
-        Try <a href="{{ wipe_url }}">reseting it</a>.
-        {% endblocktrans %}
-      </p>
-    {% endif %}
-
-    {% if not build.success and "setup.py install" in build.commands.last.output %}
-      <p>
-        {% url 'projects_advanced' build.version.project.slug as advanced_url %}
-        {% blocktrans %}
-        Don't want <em>setup.py install</em> called?
-        Change the <strong>Install Project</strong> setting in your <a href="{{ advanced_url }}">advanced settings</a>.
-        {% endblocktrans %}
-      </p>
+      <div class="build-ideas">
+        <p>
+          {% url 'wipe_version' build.version.project.slug build.version.slug as wipe_url %}
+          {% blocktrans %}
+            Having trouble with your build environment?
+            Try <a href="{{ wipe_url }}">reseting it</a>.
+          {% endblocktrans %}
+        </p>
+      </div>
+    {% elif not build.success and "setup.py install" in build.commands.last.output %}
+      <div class="build-ideas">
+        <p>
+          {% url 'projects_advanced' build.version.project.slug as advanced_url %}
+          {% blocktrans %}
+            Don't want <em>setup.py install</em> called?
+            Change the <strong>Install Project</strong> setting in your <a href="{{ advanced_url }}">advanced settings</a>.
+          {% endblocktrans %}
+        </p>
+      </div>
     {% endif %}
-    </div>
 
     {% if build.output %}
       {# If we have build output, this is an old build #}