Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project: dashboard view shows private buttons in public view #152

Closed
agjohnson opened this issue Mar 10, 2023 · 2 comments
Closed

Project: dashboard view shows private buttons in public view #152

agjohnson opened this issue Mar 10, 2023 · 2 comments
Assignees
@agjohnson
Labels
Accepted Accepted issue on our roadmap Bug A bug
Milestone
Template private ...

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Mar 10, 2023 •
edited
Loading

Loading a project dashboard page anonymously, I can see various admin only buttons:

https://beta.readthedocs.org/projects/docs/

Image

There should be template logic protecting this, but verify the queries are correct by comparing the current dashboard template logic around these elements.

Also, the JS is broke in this case. I suspect it's an out of date bundle, maybe not relevant.
@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap labels Mar 10, 2023
@agjohnson agjohnson self-assigned this Mar 10, 2023
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Mar 10, 2023
@agjohnson agjohnson moved this from Planned to In progress in 📍Roadmap Mar 10, 2023
@agjohnson agjohnson moved this from In progress to Planned in 📍Roadmap Mar 10, 2023
@agjohnson
Copy link
Contributor Author

The JS error is not a out of date bundle but is instead a problem with the API. The response for a unauthed user from the v3 API is a 401 response. We have talked about making the detail view on version/projects a public API, which would resolve this issue. Otherwise, I'm not sure there is anything that easily solves this.

agjohnson added a commit that referenced this issue Mar 27, 2023
@agjohnson
Project version list public view fixes and some UI updates
5aac3e8 
Mostly adds checks for admin access on the version list page. There are
a few small icon and text tweak snuck in while I was touching these
already.

This addresses #152, but
the public view JS issue still stands. I'll break that out to a separate
conversation.
@agjohnson agjohnson mentioned this issue Mar 27, 2023
Closed
@agjohnson
Copy link
Contributor Author

Split out that particular conversation to #154

@github-project-automation github-project-automation bot moved this from Planned to Done in 📍Roadmap Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agjohnson agjohnson

Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
📍Roadmap
Archived in project
Milestone
Template private beta - community
Development

No branches or pull requests
1 participant
@agjohnson