Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post: deprecation of building without config file #219

Merged
merged 9 commits into from
May 31, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented May 29, 2023

Initial blog post to point users to when talking about the deprecation of "building without a configuration file".

I'm not mentioning a specific date on purpose here because we don't know yet. However, I'm mentioning Sept 2023 because our goal is to match with the drop of OpenSSL 1.1.1 support on urllib. We can update the post once we know this exact date and also write a new pretty small blog post with an update of the exact date later if we want to, but may not be necessary tho.

Once this blog post is published, we can update some links in the application to point users to this post also.

Note that I wrote a "suggested configuration file" and alos describe some of the differences, so users can dig a little more in case they start getting some errors. I don't want to give them just a blob of YAML without guiding the a little in the process.

📚 Rendered version 📚 : https://readthedocs-blog--219.org.readthedocs.build/migrate-configuration-v2/

Related readthedocs/readthedocs.org#10351

Initial blog post to point users to when talking about the deprecation of
"building without a configuration file".

I'm not mentioning a specific date on purpose here because we don't know yet.
However, I'm mentioning Sept 2023 because our goal is to match with the drop of
OpenSSL 1.1.1 support on `urllib`. We can update the post once we know this
exact date and also write a new pretty small blog post with an update of the
exact date later if we want to, but may not be necessary tho.

Once this blog post is published, we can update some links in the application to
point users to this post also.

Note that I wrote a "suggested configuration file" and alos describe some of the
differences, so users can dig a little more in case they start getting some
errors. I don't want to give them just a blob of YAML without guiding the a
little in the process.
@humitos humitos requested a review from agjohnson May 29, 2023 15:00
@humitos humitos requested a review from a team as a code owner May 29, 2023 15:00
@humitos
Copy link
Member Author

humitos commented May 29, 2023

I tested my suggested configuration file works at https://readthedocs.org/projects/test-builds/builds/20852204/

Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal is great 💯 Deprecation notice, September 2023 deadline, give people a simple example and a solid checklist about how it might be customized 👍

All my comments here are about optimizing the blog post's content and making the information clearer.

I'm happy to give a second review quickly.

I think this should go out BEFORE the June newsletter and BEFORE the deprecation notification are added in builds (because then the deprecation warning can link to this blog post!)

This blog post can be the main message in the June newsletter, which makes the newsletter more important and gives the blog post added exposure.

humitos added 3 commits May 30, 2023 17:27
- add sections to split the content
- expand the bullets list to mention the dashboard settings and the
  corresponding YAML config key
- fix some typos
@humitos
Copy link
Member Author

humitos commented May 30, 2023

@benjaoming Thanks for the review 👍🏼. I took some suggestions that I found good and easy to apply. In particular, the addition of sections and the expansion of the dashboard settings since they have to be migrated as well. That was a good point that I missed 💯

@humitos
Copy link
Member Author

humitos commented May 31, 2023

OK. I will move forward with this PR and merge it so it's published and I can continue with the deprecation emails and notifications. I'm happy to come back to this blog post and update it as needed once people start reading it and having doubts/questions/things that are not clear.

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change the structure, that all looked good. I did and a couple sentences to make things a little more clear. Otherwise, just a flood of copy and grammar edits.

@humitos humitos merged commit a9595b7 into main May 31, 2023
@humitos humitos deleted the humitos/migrate-to-config-v2 branch May 31, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants