fix(build): inform rollup of react-popper exports

[TheSharpieOne]

This brings react-popper back to ^0.8.2, but adds some rollup config to allow the build to deal with how react-popper is defining the exports.

CC @supergibbs

[virgofx]

@TheSharpieOne can you zip up the output bundles and attach those and I'll test the external mechanism as outlined in that other issue to make sure this works.

[supergibbs]

Nice workaround!

[TheSharpieOne]

@virgofx https://gist.github.com/TheSharpieOne/c329933e65ad9e4821c1784a686ea40c

[virgofx]

👍 will test later tonight (hopefully if time permits)

[virgofx]

Tested with the version you linked. There's still a build error when running Server Side rendering.

Line 8:

TypeError: Cannot use 'in' operator to search for 'default' in undefined

var ReactDOM__default = 'default' in ReactDOM ? ReactDOM['default'] : ReactDOM;

It looks like this is a result of the ReactPortal as outlined in that other issue. The importing of the react-portal seems to maybe mess up a few things:

OLD WORKING CODE:

var ReactDOM__default = ReactDOM && 'default' in ReactDOM ? ReactDOM['default'] : ReactDOM;

NEW LINE:

var ReactDOM__default = 'default' in ReactDOM ? ReactDOM['default'] : ReactDOM;

Since ReactDOM is undefined on the server side you'd expect this to be undefined without erroring. Not sure how to get this back?

The rendering of portals done in react-portal and react-popper both use proper utility classes to ensure rendered content does NOT happen on the server side, so I'm not sure where this is happening from.

Side note: It looks like prop-types is now getting included from the react-portal package as well. Size is up from 164KB uncompressed to 178KB - beta.2/ or 180KB with this version. It shouldn't be hard to include the remove prop-types babel plugin as it's pretty safe.

[TheSharpieOne]

@virgofx so what is the fix for TypeError: Cannot use 'in' operator to search for 'default' in undefined? Do we just add another edit to the postbuild script to change
var ReactDOM__default = 'default' in ReactDOM ? ReactDOM['default'] : ReactDOM; to var ReactDOM__default = ReactDOM && 'default' in ReactDOM ? ReactDOM['default'] : ReactDOM;

[virgofx]

Let me look at it tomorrow. We could do that ... I'd like to know why it changed. Not sure if it's a rollup change , or because of the way we're using one of our dependencies.

[TheSharpieOne]

This is not longer needed.