-
-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: total value shows NaN when an expense with 0 amount #1574
fix: total value shows NaN when an expense with 0 amount #1574
Conversation
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
I have completed the changes and the pull request is now ready for your review. Please let me know if you have any questions or need further clarification. Thank you! |
Thanks for the PR @anuj-kumary , can you link the relevant issue? |
The issue link has already been included in the PR description. Please let me know if there's anything else you'd like me to update. |
@anuj-kumary , need to link in below format. Fixes #1573 |
Done |
Description
Summary of the Change:
Issue Fixed:
When adding an expense without specifying the amount field, the total displayed was NaN instead of the expected numeric value. This disrupted the accuracy of expense calculations in the tracker.
Fixes #1573
Type of change
How Has This Been Tested?
Amount
field entirely.Checklist:
Screenshots or example output
Screen.Recording.2024-11-23.at.11.18.12.PM.mov