Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plays): add dictionary play #1567

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

Ananya-Bhardwaj
Copy link
Contributor

@Ananya-Bhardwaj Ananya-Bhardwaj commented Oct 29, 2024

Description

Add new dictionary play to fetch and display the definition, pronunciation, antonyms and synonyms of a word entered by user

Fixes #1566

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual Testing using Playwright

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

Add new dictionary play to fetch and display the definition,
pronunciation, antonyms and synonyms of a word entered by user
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 56d33e4
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/67212a3f95990b0008aa0876
😎 Deploy Preview https://deploy-preview-1567--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Ananya-Bhardwaj
Copy link
Contributor Author

Do I need to make some changes @priyankarpal ?

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal
Copy link
Member

Do I need to make some changes @priyankarpal ?

nope

@priyankarpal priyankarpal merged commit afd7254 into reactplay:main Oct 31, 2024
7 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[#2PlaysAMonth]: Dictionary Play
2 participants