Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature play zoomlogin #1516

Merged
merged 16 commits into from
Oct 9, 2024
Merged

Feature play zoomlogin #1516

merged 16 commits into from
Oct 9, 2024

Conversation

day-lee
Copy link
Contributor

@day-lee day-lee commented Sep 25, 2024 •
edited
Loading

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

  • I added a new play: zoom login and chatbot clone project.
  • I fixed an existing play 'schulte-tables' as it used plain class name '.flex' and overrided tailwind classnames and made mess. This can potentially happen to future work hence I editted it to have a more specific name (.flex -> .schulte-tables-flex)
  • dependencies: react-chatbot-kit

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 39a2034
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/67028ed4cdfe71000838b47f
😎 Deploy Preview https://deploy-preview-1516--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Sep 25, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

priyankarpal
priyankarpal requested changes Sep 26, 2024
View reviewed changes
@priyankarpal priyankarpal added the changes required need to change some thing label Sep 26, 2024
@priyankarpal
Copy link
Member

thanks for fixing

I fixed an existing play 'schulte-tables' as it used plain class name '.flex' and overrided tailwind classnames and made mess. This can potentially happen to future work hence I editted it to have a more specific name (.flex -> .schulte-tables-flex)

@day-lee
fix: replace img, remove code (reactplay#1512)
5790e22 
* fix: replace svg and png logo images to cdn link

* fix: add guiding sentences in header

* fix: delete direct DOM manipulation code

---------

Co-authored-by: Priyankar Pal <[email protected]
reply.github.com>.
@day-lee
Merge branch 'feature-play-zoomlogin' of https://github.com/day-lee/r…
19eb91a 
…eact-play into feature-play-zoomlogin
priyankarpal
priyankarpal requested changes Sep 28, 2024
View reviewed changes
@day-lee @priyankarpal
refactor: remove unused file, refactor css code(reactplay#1512)
471c03d 
* refactor: remove App.css file

* refactor: change sticky header top value

---------

Co-authored-by: Priyankar Pal <[email protected]>
@priyankarpal
Copy link
Member

let me check

@priyankarpal
Copy link
Member

@day-lee Could you please check the responsive design?

Screenshot_2024-10-02_18_13_46

Sachin-chaurasiya and others added 7 commits October 3, 2024 16:57
@Sachin-chaurasiya
Merge branch 'main' into feature-play-zoomlogin
8aab92e
@day-lee @priyankarpal
refactor: change the assets and footer style for responsive design (r…
2c0991d 
…eactplay#1512)

* refactor: replace zoom help icon with transparent background

* refactor: change footer text size for mobile screen

---------

Co-authored-by: Priyankar Pal <[email protected]>
@day-lee @priyankarpal
refactor: add the modal (reactplay#1512)
4bc6e5f 
* refactor: remove the guide sentences in the header add the modal

---------

Co-authored-by: Priyankar Pal <[email protected]>
@day-lee
Merge branch 'feature-play-zoomlogin' of https://github.com/day-lee/r…
c087b20 
…eact-play into feature-play-zoomlogin
@day-lee
refactor: fix mobile responsive design for chatbot (reactplay#1512)
a550ce4 
* refactor: fix mobile responsive design for chatbot

---------

Co-authored-by: Priyankar Pal <[email protected]>i
@day-lee @priyankarpal
refactor: clean up the code (reactplay#1512)
251444d 
* refactor: clean up the unused function and import

---------

Co-authored-by: Priyankar Pal <[email protected]>
@priyankarpal
Merge branch 'main' into feature-play-zoomlogin
39a2034
@priyankarpal priyankarpal removed the changes required need to change some thing label Oct 6, 2024
@priyankarpal priyankarpal merged commit ee6d5fd into reactplay:main Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@priyankarpal priyankarpal priyankarpal approved these changes

Assignees

@day-lee day-lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@day-lee @priyankarpal @Sachin-chaurasiya