Add GH Action test matrix for OS/netty/transport #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbasle
added
status/need-triage
simonbasle
force-pushed
the
testNativeTransports
branch
from
c7aa76e to
ae031b2
Compare
violetagg
removed
the
status/need-triage
violetagg
requested changes
Oct 25, 2019
simonbasle
force-pushed
the
testNativeTransports
branch
2 times, most recently
from
b55d62a to
1d58126
Compare
By using the Gradle property `forceNettyVersion`, one can select an arbitrary version of Netty, eg. to run tests with the latest snapshots in CI in parallel to the current release. Snapshot repository for Netty is also added in case the current reactor version is a snapshot itself.
The `forceTranport` property can be used to choose between `nio` and `native` when running Gradle tasks like tests. This allows to select the underlying transport to active, eg. when running a test matrix in CI.
This Action performs tests (clean check) in all three OS using NIO, plus an additional run with epoll on Linux and an additional run with KQueue on OSX. It replaces the former Java CI action.
simonbasle
force-pushed
the
testNativeTransports
branch
from
1d58126 to
92e8265
Compare
violetagg
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow and build changes allow to:
execute tests using 3 different versions of netty for each OS+transport pairThe 3 netty versions are only relevant while #844 is open. In the future this should be switched todefault+snapshot, to run tests with netty snapshots.Note that kqueue has a publication issue (see comment in netty/netty#8100, might need to open another issue for visibility since this one was closed) so all snapshots aren't available, this case should be excluded from the build matrix if relevant.