Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an idea to support dynamic https like (caddy server) #2156

Closed
ashraf-revo opened this issue Apr 19, 2022 · 2 comments
Closed

an idea to support dynamic https like (caddy server) #2156

ashraf-revo opened this issue Apr 19, 2022 · 2 comments
Assignees
Labels
type/enhancement A general enhancement
Milestone

Comments

@ashraf-revo
Copy link
Contributor

Motivation

i hope if we could support tls lazy load certificates by domain
this might help us in renew the certificates (using letsencrypt or other)
support dynamic https like (caddy server)
see https://caddyserver.com/docs/quick-starts/https

Desired solution

add function to load certificates by domain as key
we could implment this function to renew or generate ssl certificate

@ashraf-revo ashraf-revo added status/need-triage A new issue that still need to be evaluated as a whole type/enhancement A general enhancement labels Apr 19, 2022
@violetagg
Copy link
Member

@ashraf-revo Are you interested in providing a PR?

@ashraf-revo
Copy link
Contributor Author

ashraf-revo commented Apr 21, 2022

@violetagg after check the code i found that it could be done if we create new method SniProvider.newSniHandler
that use the io.netty.handler.ssl.SniHandler not reactor.netty.tcp.SniProvider.AdvancedSniHandler because it not use the power of AsyncMapping<String, SslContext> and overide io.netty.handler.ssl.SniHandler.lookup to return Future<SslContext> from pre passed function Function<String,Future<SslContext>>

@violetagg violetagg self-assigned this Apr 26, 2022
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label Apr 27, 2022
violetagg added a commit that referenced this issue Apr 29, 2022
@violetagg violetagg added this to the 1.0.19 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants