Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean maintainers #3

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Add Korean maintainers #3

merged 2 commits into from
Feb 7, 2019

Conversation

simsim0709
Copy link
Contributor

This is PR for translations in Korean.

A little bit of my translation and open source projects:

translation
https://www.vobour.com/series/it-%EB%B8%94%EB%A1%9C%EA%B7%B8-%EB%B2%88%EC%97%AD

open source
https://github.com/learn-vuejs/vue-patterns/

@tesseralis, I just sent messages to 2 people who speak Korean, and I'm waiting for a response.
Could you add them later or merge this pr a little bit later?

Thanks.

This is PR for translations in Korean.

A little bit of my translation and open source projects:

translation
https://www.vobour.com/series/it-%EB%B8%94%EB%A1%9C%EA%B7%B8-%EB%B2%88%EC%97%AD

open source
https://github.com/learn-vuejs/vue-patterns/

@tesseralis, I just sent messages to 2 people who speak Korean, and I'm waiting for a response. 
Could you add them later or merge this pr a little bit later?

Thanks.
@tesseralis
Copy link
Member

I'll wait to merge the PR :)

@gnujoow
Copy link
Member

gnujoow commented Feb 7, 2019

@simsim0709

I would like to contribute Korean translation ;)
I have some experience of translating documents via yarn.org and MDN.

https://developer.mozilla.org/ko/dashboards/revisions?user=gnujoow
https://crowdin.com/profile/gnujoow

could you list my username @gnujoow on PR commit? or should I send another PR? @tesseralis

:)

@tesseralis
Copy link
Member

@gnujoow could you tell us a little bit about your experience with translating or open source?

@gnujoow
Copy link
Member

gnujoow commented Feb 7, 2019

@tesseralis

I translated a page of https://github.com/orgs/solidity-korea/ and https://github.com/aikorea/cs231n and made glossary for better translation, translated few pages of yarn on crowdin.


for open source, I haven't contributed on code level but have fixed some open sources' document.

As someone who really likes React, I would appreciate enormously if i could contribute ;)

@b9words
Copy link

b9words commented Feb 7, 2019

@simsim0709 @tesseralis

Hi, I would also like to contribute to Korean translation. I have not participated in open source projects before, but am very experienced in language localization & en-ko translations.

I headed the localization of Storefront (real-estate IT platform) in Korea, and am participating in multinational blockchain project (precium.io) as a core developer. My credentials can be viewed at https://www.linkedin.com/in/jinyong-kim/ for your reference :)

I really hope I can contribute to this awesome project!

@hg-pyun
Copy link
Member

hg-pyun commented Feb 7, 2019

@simsim0709
Thank you for email. I want to react translations :D
Here are my experience.

Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"maintainers": ["simsim0709", "hg-pyun"]

@simsim0709
Copy link
Contributor Author

Thanks all, @hg-pyun @gnujoow @b9words

I'm not sure if I have in charge of adding maintainers on the list. I'd better wait for @tesseralis 's confirm, then I will change it.

@tesseralis
Copy link
Member

Yeah! Go ahead and add them :)

@tesseralis
Copy link
Member

I'm going to add everyone and merge it in. Thanks everyone!

@tesseralis tesseralis merged commit 1a841dc into reactjs:master Feb 7, 2019
@tesseralis
Copy link
Member

@simsim0709 I've created a repo for you! You should have received an invite to join the react organization. Happy translating :)

@simsim0709
Copy link
Contributor Author

@tesseralis some other people want to join the Korean translation repo.
Can I manage "collaborators & teams" of Korean translation repo?

Thanks.

@tesseralis
Copy link
Member

You should be able to add them here: https://github.com/orgs/reactjs/teams/reactjs-org-korean-translation/members

And this will give them access to the repo!

@deminoth
Copy link

deminoth commented Feb 8, 2019

@simsim0709
Copy link
Contributor Author

Hi, @deminoth

Korean translation repo is here https://github.com/reactjs/ko.reactjs.org/

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants