Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase clarity of Context documentation #3527

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

mushmelty
Copy link
Contributor

There are a number of places on this page in which antecedents are vague or nebulous, and may prove troublesome for a reader's initial encounter with the material. I have made a few changes that I hope will clarify the authors' intentions and reduce the need for re-reading.

There are a number of places on this page in which antecedents are vague or nebulous, and may prove troublesome for a reader's initial encounter with the material. I have made a few changes that I hope will clarify the authors' intentions and reduce the need for re-reading.
@facebook-github-bot
Copy link
Collaborator

Hi @mushmelty!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built without sensitive environment variables with commit 29648a6

https://deploy-preview-3527--reactjs.netlify.app

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak to the semicolon but I really like the other changes 👍

In order to be able to merge this you have to sign the CLA though.

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@eps1lon eps1lon merged commit 47e444a into reactjs:master Feb 16, 2021
@mushmelty mushmelty deleted the patch-1 branch February 16, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants