Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated paths to UMD builds for React and React-DOM in 'How to Contribute' page #3523

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Updated paths to UMD builds for React and React-DOM in 'How to Contribute' page #3523

merged 1 commit into from
Feb 23, 2021

Conversation

tsairinius
Copy link
Contributor

@tsairinius tsairinius commented Feb 13, 2021

After building react (using either yarn build or yarn build react/index,react-dom/index --type=UMD), the resulting UMD builds no longer reside at build/dist/react.development.js and build/dist/react-dom.development.js, which is what is currently documented (see How to Contribute:

If you want to try your changes in your existing React project, you may copy build/dist/react.development.js, build/dist/react-dom.development.js, or any other build products into your app and use them instead of the stable version.

The builds now appear to be located at build/node_modules/react/umd/react.development.js and build/node_modules/react-dom/umd/react-dom.development.js. This PR updates the paths in the documentation.

Opened an issue for this: #3524

@facebook-github-bot
Copy link
Collaborator

Hi @tsairinius!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built without sensitive environment variables with commit 19b06ba

https://deploy-preview-3523--reactjs.netlify.app

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@rickhanlonii rickhanlonii merged commit f73dcf1 into reactjs:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants