Added alternative to findDOMNode #514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silvenon any chance this PR can get reviewed? |
eps1lon
reviewed
Sep 15, 2019
|
|
||
| it('uses transitionNode when provided', () => { | ||
| const onEnterSpy = jest.fn(); | ||
| const transitionNode = document.createElement('span'); |
There was a problem hiding this comment.
But that is not the element that is transitioning. It should be the child of Transition which is a div in this case.
4 tasks
|
This is a good start to drop Good transitional release before upgrading code base to the next major release |
|
🎉 This issue has been resolved in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach provides an alternative to
ReactDOM.findDOMNodefor those who would like to enableReact.StrictModewithout console errors fromreact-transition-group.