Update react-modal to work with React v0.14 and fix deprectated warnings. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +47,7 @@ | |||
| "element-class": "^0.2.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": ">=0.13.3" | |||
| "react": ">=0.14.0.rc1" | |||
There was a problem hiding this comment.
@rogeliog Thanks for your great work. I'm currently using your fork now but getting an error on npm install because of this. I guess it should be -rc1 instead of .rc1.
|
@rogeliog Looks like React 0.14 support was already merged in as of version 0.6.0. I'm going to go ahead and close this one out to clean things up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
It might be a good idea to wait until React v0.14.0 gets released or maybe we can merge it in react-0.14 branch
😄