Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support react-test-renderer #26

Merged
merged 1 commit into from
May 11, 2018
Merged

Support react-test-renderer #26

merged 1 commit into from
May 11, 2018

Conversation

Hypnosphi
Copy link
Contributor

@gaearon
Copy link
Member

gaearon commented May 11, 2018

Can you also send a PR to React itself to align the behavior of shallow and normal rendering?

@bvaughn bvaughn self-assigned this May 11, 2018
@Hypnosphi
Copy link
Contributor Author

@gaearon sure, will do

@bvaughn
Copy link
Contributor

bvaughn commented May 11, 2018

Thanks for the fix and the added tests, @Hypnosphi !

@bvaughn
Copy link
Contributor

bvaughn commented May 11, 2018

Published as 3.0.4

@bvaughn bvaughn merged commit 0440249 into reactjs:master May 11, 2018
@Hypnosphi
Copy link
Contributor Author

Here's React PR facebook/react#12784

@dependencies dependencies bot mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bvaughn bvaughn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hypnosphi @gaearon @bvaughn