feat: generate code that uses Array.Empty where possible
#1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaisbetts
reviewed
Nov 14, 2023
anaisbetts
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
This is great, thanks for the solid PR. @clairernovotny, can you think of anything this might break?
TimothyMakkison
force-pushed
the
improve_empty_array
branch
5 times, most recently
from
f83b635 to
19870d6
Compare
clairernovotny
approved these changes
Nov 15, 2023
|
Can't think of any issues this would cause. Thanks! |
TimothyMakkison
force-pushed
the
improve_empty_array
branch
from
19870d6 to
dcd75f6
Compare
TimothyMakkison
force-pushed
the
improve_empty_array
branch
from
dcd75f6 to
9f8883d
Compare
|
Sorry about that, should be fixed now 🤞 Any chance you'd be open to running a formatter on this repository? A lot of lines appear to have random 4-8 sections of whitespace. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1599 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 33 33
Lines 1685 1685
Branches 295 295
=======================================
Hits 1440 1440
Misses 166 166
Partials 79 79 ☔ View full report in Codecov by Sentry. |
1 task
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Array.Emptyover allocating an empty array where possible. Done for______argumentsandparameterTypes..See #1598