feature: Allow InvokeCommand to use IReactiveCommand<T, TResult> #3681
Conversation
glennawatson
changed the title
|
Oh, build failures kicked in. I'll take a look later. |
|
Was just discussing this one between myself and @ChrisPulman I think this one might have to be a reject, due to the nature of C# If the parameters only change based on having two interfaces, C# can't handle it and will cause ambiguity The solutions you could potentially do is create a new method Also then there is a argument why aren't you using ReactiveCommandBase if you're using a IReactiveCommand I think it was definitely a nice to have one if the compiler could handle the two interface declarations and would of supported it going in, but unfortunately in this case I don't want to have method name changes imposed on existing code base etc. Seemed simple but unfortunately not. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Use interface intead of implementation.
What is the current behavior?
InvokeCommand cannot be used with instances of
IReactiveCommand<T, TResult>What is the new behavior?
InvokeCommand can be used with instances of
IReactiveCommand<T, TResult>What might this PR break?
Nothing.
Please check if the PR fulfills these requirements
Other information:
Minor change. Should be fine.