Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Release 14.1 #2792

Merged
merged 3 commits into from
Jun 19, 2021
Merged

housekeeping: Release 14.1 #2792

merged 3 commits into from
Jun 19, 2021

Conversation

glennawatson
Copy link
Contributor

No description provided.

@glennawatson glennawatson added the release Gets released. label Jun 15, 2021
@worldbeater
Copy link
Contributor

worldbeater commented Jun 15, 2021

Error: D:\a\ReactiveUI\ReactiveUI\src\ReactiveUI\RegistrationNamespace.cs(15,1): error RCS1037: Remove trailing white-space. [D:\a\ReactiveUI\ReactiveUI\src\ReactiveUI\ReactiveUI.csproj]
Error: D:\a\ReactiveUI\ReactiveUI\src\ReactiveUI\RegistrationNamespace.cs(15,1): error SA1028: Code should not contain trailing whitespace [D:\a\ReactiveUI\ReactiveUI\src\ReactiveUI\ReactiveUI.csproj]
Error: D:\a\ReactiveUI\ReactiveUI\src\ReactiveUI\RegistrationNamespace.cs(15,1): error RCS1037: Remove trailing white-space. [D:\a\ReactiveUI\ReactiveUI\src\ReactiveUI\ReactiveUI.csproj]
Error: D:\a\ReactiveUI\ReactiveUI\src\ReactiveUI\RegistrationNamespace.cs(15,1): error SA1028: Code should not contain trailing whitespace [D:\a\ReactiveUI\ReactiveUI\src\ReactiveUI\ReactiveUI.csproj]

Analyzers seem to be complaining

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #2792 (4362262) into main (0312f8b) will decrease coverage by 0.05%.
The diff coverage is 89.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2792      +/-   ##
==========================================
- Coverage   63.57%   63.52%   -0.06%     
==========================================
  Files         132      134       +2     
  Lines        4733     4688      -45     
==========================================
- Hits         3009     2978      -31     
+ Misses       1724     1710      -14     
Impacted Files Coverage Δ
...rvableCollectionChangedToListChangedTransformer.cs 0.00% <0.00%> (ø)
...ctiveUI.Winforms/PanelSetMethodBindingConverter.cs 13.33% <0.00%> (ø)
src/ReactiveUI.Wpf/TransitioningContentControl.cs 9.09% <0.00%> (ø)
src/ReactiveUI/Activation/ViewModelActivator.cs 81.81% <ø> (ø)
src/ReactiveUI/Bindings/Command/CommandBinder.cs 93.33% <ø> (ø)
...dings/Command/CommandBinderImplementationMixins.cs 83.33% <ø> (ø)
...ommand/CreatesCommandBindingViaCommandParameter.cs 93.10% <ø> (ø)
...ngs/Interaction/InteractionBinderImplementation.cs 83.33% <ø> (ø)
src/ReactiveUI/Comparers/OrderedComparer.cs 63.63% <ø> (ø)
src/ReactiveUI/Mixins/ObservableLoggingMixin.cs 0.00% <0.00%> (-28.58%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0704d19...4362262. Read the comment docs.

@ChrisPulman ChrisPulman merged commit 49784a2 into main Jun 19, 2021
@ChrisPulman ChrisPulman deleted the glennawatson-patch-1 branch June 19, 2021 12:25
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release Gets released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants