Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Azure Blob image URL will throw an exception when there are invalid values #333

Closed
AigioL opened this issue Sep 19, 2023 · 1 comment
Closed

[Bug]: Azure Blob image URL will throw an exception when there are invalid values #333

AigioL opened this issue Sep 19, 2023 · 1 comment
Labels
Bug

Comments

@AigioL
Copy link
Contributor

AigioL commented Sep 19, 2023 •
edited
Loading

Describe the bug 🐞

A bug happened!

Azure Blob image URL will throw an exception when there are invalid values

https://github.com/reactiveui/Fusillade/blob/2.4.67/src/Fusillade/RateLimitedHttpMessageHandler.cs#L176-L180

Changing here should fix this issue
Use HttpHeaders.TryAddWithoutValidation Method

e6644dad5a1d1c15191594e408c59b2b

https://blob.steampp.net:443/jpeg/deb006f3186f2bf5c905f8e55f3d35e7bf24319a2f2143ab4cafffc5fcc00f817e30bd6d2c3a580d4423755f4f8f08f2.jpg

fe9be287cdb946f48556bbe2bfacefd8

Step to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Reproduction repository

https://github.com/reactiveui/ReactiveUI

Expected behavior

This should happen...

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

No response

Device

No response

ReactiveUI Version

No response

Additional information ℹ️

No response
@AigioL AigioL added the Bug label Sep 19, 2023
@AigioL AigioL changed the title [Bug]: [Bug]: Azure Blob image URL will throw an exception when there are invalid values Sep 19, 2023
AigioL added a commit to AigioL/Fusillade that referenced this issue Sep 19, 2023
@AigioL
fix: System.FormatException reactiveui#333
de78cad
@AigioL AigioL mentioned this issue Sep 19, 2023
Merged
2 tasks
ChrisPulman pushed a commit that referenced this issue Sep 19, 2023
@AigioL
fix: System.FormatException #333 (#334)
627c936
@AigioL AigioL closed this as completed Sep 21, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AigioL