Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 -- Remove --open call on npm start #46

Open
1 of 2 tasks
sthzg opened this issue Aug 10, 2016 · 5 comments
Open
1 of 2 tasks

V2 -- Remove --open call on npm start #46

sthzg opened this issue Aug 10, 2016 · 5 comments
Assignees
Milestone

Comments

@sthzg
Copy link
Member

sthzg commented Aug 10, 2016

As brought up in generator-react-webpack #266

V2

  • remove the --open call on npm start
  • log dev server address to console after the inital webpack build is ready

@weblogixx should I tackle this?

@weblogixx
Copy link
Member

Hi @sthzg, sure just go ahead.

@sthzg sthzg changed the title Remove --open call on npm start V2 -- Remove --open call on npm start Aug 11, 2016
@sthzg
Copy link
Member Author

sthzg commented Aug 11, 2016

@weblogixx I've split this issue out in two:

#46 => V1
#47 => V2.

In the V2 version npm start directly invokes the webpack-dev-server cli, so there is no way that I know of to listen for the end of the (first) compilation to print a message to the console afterwards. Webpack however prints it by default on the very top (which after bundling is in the scrollback).

If this isn't good enough I don't see another way than bootstrapping the webpack-dev-server in a script file so that we can register a listener to when the first compilation is done (as a reference the implementation in the V1 branch).

@weblogixx
Copy link
Member

Yes, there seems to be no way to do this with the command line currently :(. Have to think about that.

@sthzg
Copy link
Member Author

sthzg commented Aug 13, 2016

Would there be something speaking against a devserver.js script in the root dir (like it has been in V3 with server.js)? After all, it seems to be just a small wrapper around the CLI, or am I missing something?

@weblogixx
Copy link
Member

The only reason I removed it was that there is one file less and you can parse cli args into the launcher directly.

@sthzg sthzg added this to the 2.0 milestone Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants