Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 -- Inspect problems for Travis build on Node 4 #35

Closed
sthzg opened this issue Jul 11, 2016 · 1 comment
Closed

V2 -- Inspect problems for Travis build on Node 4 #35

sthzg opened this issue Jul 11, 2016 · 1 comment
Assignees
@sthzg

Comments

@sthzg
Copy link
Member

sthzg commented Jul 11, 2016

Currently the build on Node 4 / npm 3 fails due to unsatisfied peer deps. As tests pass with npm 3, we decided to update the npm requirement to 3+ and test whether the build passes again.

The general issue with unsatisfied peer deps is discussed in this issue react-webpack-generators/generator-react-webpack#252.
@sthzg sthzg self-assigned this Jul 11, 2016
sthzg added a commit that referenced this issue Jul 11, 2016
@sthzg
Updated .travis.yml to ensure npm3 for tests #35
730576c
sthzg added a commit that referenced this issue Jul 11, 2016
@sthzg
Set karma.conf.js to use strict mode #35
48d0076
sthzg added a commit that referenced this issue Jul 11, 2016
@sthzg
Set karma.conf.js to use strict mode #35
e4a221c
sthzg added a commit that referenced this issue Jul 11, 2016
@sthzg
Set karma.conf.js to use strict mode #35
0b6f953
@sthzg sthzg mentioned this issue Jul 11, 2016
Merged
sthzg added a commit that referenced this issue Jul 11, 2016
@sthzg
Fixes #35 -- update npm req for Travis to v3+ (#36)
2db0659 
- updated .travis.yml to ensure npm3 for tests #35
- explicitly set various config files in strict mode to silence errors about unsupported keywords (let, const, ...) on Node 4
@sthzg
Copy link
Member Author

sthzg commented Jul 11, 2016

Closed with #36

@sthzg sthzg closed this as completed Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sthzg sthzg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sthzg