Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the structure of global and semantic design tokens and explain how they are related #457

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

adamkudrna
Copy link
Member

@adamkudrna adamkudrna commented Mar 6, 2023

Set global and semantic tokens apart and improve the documentation.

⚠️ Breaking changes:

  • Renamed link color tokens from --rui-color-action-link(-*) to --rui-color-text-link(-*).
  • Removed internal design token --rui-ratio-disabled-cursor in favour of --rui-cursor-not-allowed.

Copy link
Member Author

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update branch name and commit message.

src/docs/foundation/design-tokens.mdx Outdated Show resolved Hide resolved
src/docs/foundation/design-tokens.mdx Outdated Show resolved Hide resolved
src/docs/foundation/colors.mdx Outdated Show resolved Hide resolved
src/docs/foundation/accessibility.mdx Outdated Show resolved Hide resolved
src/lib/theme.scss Show resolved Hide resolved
src/lib/theme.scss Outdated Show resolved Hide resolved
@adamkudrna adamkudrna force-pushed the refactor/design-tokens branch from f63b6dd to 6313fdd Compare March 8, 2023 11:58
@adamkudrna adamkudrna added the BC Breaking change label Mar 8, 2023
@adamkudrna adamkudrna changed the title Improve the structure of global and alias design tokens and explain how they are related together Improve the structure of global and alias design tokens and explain how they are related Mar 8, 2023
@adamkudrna adamkudrna changed the title Improve the structure of global and alias design tokens and explain how they are related Improve the structure of global and semantic design tokens and explain how they are related Mar 8, 2023
…n how they are related

Breaking changes:

- Renamed link color tokens from `--rui-color-action-link(-*)` to `--rui-color-text-link(-*)`.
- Removed internal design token `--rui-ratio-disabled-cursor` in favour of `--rui-cursor-not-allowed`.
@adamkudrna adamkudrna force-pushed the refactor/design-tokens branch from 6313fdd to f565038 Compare March 8, 2023 12:09
@adamkudrna adamkudrna merged commit 04b2042 into master Mar 8, 2023
@adamkudrna adamkudrna deleted the refactor/design-tokens branch March 8, 2023 12:15
@adamkudrna adamkudrna changed the title Improve the structure of global and semantic design tokens and explain how they are related Introduce the structure of global and semantic design tokens and explain how they are related Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant