Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require destructuring assignment #113

Closed
mbohal opened this issue Jun 19, 2020 · 0 comments · Fixed by #188
Closed

Require destructuring assignment #113

mbohal opened this issue Jun 19, 2020 · 0 comments · Fixed by #188
Labels
good first issue Good for newcomers maintenance refactoring
Milestone
v1.0.0

Comments

@mbohal
Copy link
Contributor

mbohal commented Jun 19, 2020

Presently we have in .eslint set "react/destructuring-assignment": "off".

We need to enable this rule and fix all errors that will come out of it.
To enable it, removing this line should be enough as it is part of the airbnb eslint config.
@mbohal mbohal mentioned this issue Jun 19, 2020
Merged
@adamkudrna adamkudrna changed the title rerquire destructuring assignment Require destructuring assignment Jun 25, 2020
@adamkudrna adamkudrna added this to the v1.0.0 milestone Jun 25, 2020
@adamkudrna adamkudrna mentioned this issue Nov 3, 2020
Merged
adamkudrna added a commit that referenced this issue Nov 5, 2020
@adamkudrna
Unify API of form components (#28, #113)
04ac8d8
@adamkudrna adamkudrna mentioned this issue Nov 5, 2020
Merged
adamkudrna added a commit that referenced this issue Nov 10, 2020
@adamkudrna
Unify API of form components (#28, #113)
8c2112a
adamkudrna added a commit that referenced this issue Nov 10, 2020
@adamkudrna
Unify API of form components (#28, #113)
fb044b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintenance refactoring
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Unify API of form components (#28, #113) react-ui-org/react-ui
2 participants
@mbohal @adamkudrna